gh-129015: Move link supression around in a Note for exceptions.rst#129562
Merged
picnixz merged 4 commits intopython:mainfrom Mar 3, 2025
nexushoratio:nexushoratio-129015
Merged
gh-129015: Move link supression around in a Note for exceptions.rst#129562picnixz merged 4 commits intopython:mainfrom nexushoratio:nexushoratio-129015
picnixz merged 4 commits intopython:mainfrom
nexushoratio:nexushoratio-129015
Conversation
This makes it similar to the same text in constants.rst.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
Member
|
Requesting @picnixz |
picnixz
added
needs backport to 3.12
AA-Turner
reviewed
Feb 16, 2025
Member
|
@nexushoratio I've taken over your branch 😈 so you can still the credited commit. Thanks for the initial work and for spotting this discrepency which is important as many users mistake those two (I was mistaken when I first started learning Python!!!) |
Member
|
@AA-Turner friendly ping |
Member
|
@AA-Turner I'd like to merge this one with the following commit title gh-129015: Clarify notes for `NotImplemented` and `NotImplementedError` (#129564) I don't really know how to explain that I changed the box from notes to caution without using sloppy English. Do you have some suggestions? |
AA-Turner
approved these changes
Mar 2, 2025
Member
|
I will take your suggestion as it indicates more cleanly what was improved. Mine was too generic. Thanks! |
|
Thanks @nexushoratio for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2025
…`NotImplementedError` (pythonGH-129562) --------- (cherry picked from commit a85eeb9) Co-authored-by: Mike Castle <dalgoda+github@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-130776 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2025
…`NotImplementedError` (pythonGH-129562) --------- (cherry picked from commit a85eeb9) Co-authored-by: Mike Castle <dalgoda+github@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-130777 is a backport of this pull request to the 3.12 branch. |
picnixz
added a commit
that referenced
this pull request
Mar 3, 2025
… `NotImplementedError` (GH-129562) (#130776) gh-129015: Improve disambiguation between `NotImplemented` and `NotImplementedError` (GH-129562) --------- (cherry picked from commit a85eeb9) Co-authored-by: Mike Castle <dalgoda+github@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
picnixz
added a commit
that referenced
this pull request
Mar 3, 2025
… `NotImplementedError` (GH-129562) (#130777) gh-129015: Improve disambiguation between `NotImplemented` and `NotImplementedError` (GH-129562) --------- (cherry picked from commit a85eeb9) Co-authored-by: Mike Castle <dalgoda+github@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it similar to the same text in constants.rst.
NotImplementedErrorandNotImplementedhave inconsistent linking #129015📚 Documentation preview 📚: https://cpython-previews--129562.org.readthedocs.build/